Repository navigation
refactor: drop protonlabs/bitcoin dependency - #203
Merged
Merged
Conversation
alfonsobries
marked this pull request as ready for review
October 21, 2026 18:15
alexbarnsley
approved these changes
Oct 22, 2026
ItsANameToo
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/86e3uf66e
drops
protonlabs/bitcoin(+ the abandonedphpecc/phpasn1it pulls in), which spam deprecations on PHP 8.4+ as soon as you sign or verify anything. ECDSA now usessimplito/elliptic-php(was already a dep), base58check / hashing / WIF live in the packagealso bumped everything to PHP 8.5: Pest 5, latest php-cs-fixer (and fixed its deprecated rules), CI on 8.5, tests moved to
it(), and removedgraham-campbell/analyzer,illuminate/supportand the parallel plugin since they aren't needed anymorebreaking, so this needs a major
^8.5PrivateKey/PublicKeynow, not the BitWasp classes.getHex(),getPublicKey()andtoWif()work the samesign()returns the DERBytes, so->sign($hash)->getBuffer()->getHex()is now->sign($hash)->getHex()getBytes()/serialize()returnBinary\Bytes(getHex()/getBinary()unchanged)AbstractNetworkdoesn't extend the BitWasp network anymore, which means arkscan needs a one-line change inapp/Contracts/Network.phpwhen it upgradestested
1.9.0(11,400 checks): signatures, keys, addresses and WIF are byte-identical@arkecosystem/crypto, must match exactlyalso fixes
Message::sign()breaking on messages that aren't valid utf-8